[patch] highlight + emblems for the places sidebar



Hello list,

attached is a patch, against git master, which adds the following to
the places-sidebar:

1 - icon highlight on hover
2 - drop-accept icon on drop-motion (only for items where it
_visually_ makes sense); addresses bgo #336985
3 - emblems; takes care of bgo #321660

The current nautilus code is not exactly friendly when it comes to
retrieve an icon for a given places-sidebar item (be it a volume, a
mount, a bookmark, whatever), so I had to basically re-implement part
of update_places. Therefore it makes sense, in a way, to:

4 -  change update_places to use the same code that the motion handler
uses as well

(I don't really like the result -- the code is slightly messier than
before -- but I can't see any simpler alternative.)

So, yeah, the patch should really be split into four parts; and if
there's interest in it, I'll gladly do that :-) I have addressed all
of these features simultaneously because they belong to the same code
path. Given its composite nature, I feel the mailing list to be a
better place than bgo to get the patch reviewed.

Does this sound like stuff desirable to have for 3.2?

Please review,

----
Stefano

Attachment: nautilus-places-sidebar-add-highlight+drop_accept+emblems.diff
Description: Binary data



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]