Problem (and the patch) when having multiple search domains on a network.

[Tomislav Vujec <tvujec redhat com>]

Hi,

When the "domainName" DHCP option contains spaces, nm-named-manager
proclaims it as invalid, although multiple domain names are often used
in the DHCP server configuration. The attached patch fixes this
behavior.

2005-02-11  Tomislav Vujec  <tvujec redhat com>

        * named/nm-named-manager.c
                - (validate_domain_list) new function for validating
			domain names lists
		- (nm_named_manager_add_domain_search) domain search
			validation done with validate_domain_list

Best regards,
-- 
Tomislav Vujec
Manager, Client Development
Red Hat  Otto-Hahn-Straße 20  85609 München-Dornach
Tel +49 89 205071 212 Fax +49 89 205071 111 Cell. +49 172 623 1214

Index: named/nm-named-manager.c
===================================================================
RCS file: /cvs/gnome/NetworkManager/named/nm-named-manager.c,v
retrieving revision 1.10
diff -u -r1.10 nm-named-manager.c
--- named/nm-named-manager.c	2 Feb 2005 22:34:16 -0000	1.10
+++ named/nm-named-manager.c	11 Feb 2005 12:38:46 -0000
@@ -566,6 +566,24 @@
 	return TRUE;
 }
 
+static gboolean
+validate_domain_list (const char *domain_list, GError **error)
+{
+	char **domain_array = g_strsplit(domain_list, " ", 0);
+	gboolean valid = TRUE;
+	char **p = domain_array;
+	
+	for (; *p; p++)
+	{
+		if (!validate_host(*p, error)) {
+			valid = FALSE;
+			break;
+		}
+	}
+	g_strfreev(domain_array);
+	return valid;
+}
+
 static void
 compute_search (gpointer key, gpointer value, gpointer data)
 {
@@ -658,7 +676,7 @@
 {
 	guint id;
 
-	if (!validate_host (domain, error))
+	if (!validate_domain_list (domain, error))
 		return 0;
 
 	id = ++mgr->priv->id_serial;

Attachment: signature.asc
Description: This is a digitally signed message part