Re: DHCP dbus name patch

[Dan Williams <dcbw redhat com>]

On Sun, 2006-02-05 at 17:07 +0100, Nikolaus Filus wrote:
> On Sunday 05 February 2006 15:00, Christoph Brill wrote:
> > Find attached a patch that replaces a hardcoded string by a define used
> > at a different place.
> 
> -       if (strncmp (interface, "com.redhat.dhcp", 15))
> +       if (strncmp (interface, DHCP_SERVICE_NAME, 15))
> 
> shouldn't it be strlen(DHCP_SERVICE_NAME) instead of the still static 15?

Yes, it should.  It's been fixed in CVS already.  Optimized too, so we
don't do strlen() every time :)

Dan