Re: NetworkManager static-routes support patch

[Dan Williams <dcbw redhat com>]

On Thu, 2007-06-07 at 13:13 -0400, Derek Atkins wrote:
> Quoting Dan Williams <dcbw redhat com>:
> 
> > On Thu, 2007-06-07 at 15:12 +0200, Blonďák wrote:
> >> Hi,
> >> i wrote patch for NetworkManager for support static-routes from DHCP
> >> (033).
> >
> > Nice!  A few comments...
> >
> > - instead of doing "(*temp_route).host", just use "temp_route->host".
> > That shows up in a few places.
> >
> > - do static routes -always- have a netmask of 0xffffffff?
> 
> -host routes do. -net routes do not.

So would the patch need to do additional checking for the routes
returned by the DHCP server to determine whether the last bit is 0 or
something?  If so, what netmask would be used instead?

Dan

> 
> -derek
>