Re: [PATCH] ModemManager: Enhancements to Icera error reporting and access technology reporting

[Aleksander Morgado <aleksander lanedo com>]

Hi Eric,

> The additional error detail allows us to know that a connection failed
> because of an invalid APN. Also, when handling access technology
> changes, report the technology in use if we're connected. Finally,
> avoid using CFUN=0 when disabling the modem. 

A small thing to fix in the patch. 

All callbacks receiving a response from the AT serial port should check
if the modem has already been removed, so in
query_network_error_code_done(), this check is needed just before trying
to parse any reply:

    /* If the modem has already been removed, return without
     * scheduling callback */
    if (mm_callback_info_check_modem_removed (info))
        return;

See
http://cgit.freedesktop.org/ModemManager/ModemManager/commit/?id=9323daec015ecad65c39b6020b62e864c027d858

Cheers!

-- 
Aleksander