Re: [PATCH] libnm-gtk: Keep the created connection in wireless dialog

[Gary Ching-Pang Lin <chingpang gmail com>]

2011/11/16 Dan Williams <dcbw redhat com>:
> On Wed, 2011-11-16 at 11:08 +0800, Gary Ching-Pang Lin wrote:
>> Although nma_wireless_dialog_get_connection() creates a NMConnection
>> object for the hidden AP, the object wasn't kept, and the function
>> would return different NMConnection objects each time.
>
> At least as it's used in nm-applet, the dialog is supposed to be
> destroyed after that function is called.  Is there some other use in the
> Gnome control center that wants it to stick around?  libnm-gtk is
> currently private API between nm-applet and the control center and it
> looks like the control center is using it correctly AFAICT.
>

In fact, it's about the patches I worked for bgo#341323. The idea of the
patch is to check the s8021x settings and issue a radius server probe if
necessary. I assumed the dialog kept the connection and checked the
s8021x settings through priv->connection, but I just found the it's not
true for the hidden AP. If this is intended, I think I have to change my
implementation in libnm-gtk.

Thanks,

Gary Lin