Re: [review] th/keyfile
- From: Dan Williams <dcbw redhat com>
- To: Thomas Haller <thaller redhat com>
- Cc: networkmanager-list gnome org
- Subject: Re: [review] th/keyfile
- Date: Fri, 13 Mar 2015 13:20:07 -0500
Hi Thomas,
About th/keyfile...
libnm: add _nm_utils_hash_values_to_ptrarray() function
What about g_hash_table_get_values() instead? It returns the values as
a GList* instead of a GPtrArray, were you just worried about memory
allocation here?
The rest looks OK to me. Do we need to update any testcases for the
sort ordering?
Dan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
