Re: [PATCH 4/5] auth: check when setting statistics refresh rate

[Beniamino Galvani <bgalvani redhat com>]

On Thu, Aug 04, 2016 at 04:16:22PM +0200, Alfonso Sanchez-Beato wrote:
> ---
>  clients/cli/general.c     |  2 ++
>  libnm/nm-client.h         |  5 ++++-
>  libnm/nm-manager.c        |  2 ++
>  shared/nm-common-macros.h |  1 +
>  src/nm-audit-manager.h    |  1 +
>  src/nm-manager.c          | 10 ++++++++++
>  6 files changed, 20 insertions(+), 1 deletion(-)

Please add the new permission to
policy/org.freedesktop.NetworkManager.policy.in.in

> --- a/src/nm-manager.c
> +++ b/src/nm-manager.c
>  static void
> @@ -5043,6 +5045,14 @@ prop_filter (GDBusConnection *connection,
>               } else
>                       return message;
>               interface_type = NMDBUS_TYPE_DEVICE_SKELETON;
> +     } else if (!strcmp (propiface, NM_DBUS_INTERFACE_DEVICE_STATISTICS)) {
> +             if (!strcmp (propname, "RefreshRateMs")) {
> +                     glib_propname = NM_DEVICE_STATISTICS_REFRESH_RATE_MS;
> +                     permission = NM_AUTH_PERMISSION_ENABLE_DISABLE_STATISTICS;
> +                     audit_op = NM_AUDIT_OP_STATISTICS;

Here you have to set @expected_type to G_VARIANT_TYPE("u") and then
handle the new property in prop_set_auth_done_cb().

B.

Attachment: signature.asc
Description: PGP signature