Re: ORBit2 threading patches ...
- From: Mark McLoughlin <mark skynet ie>
- To: Michael Meeks <michael ximian com>
- Cc: orbit-list gnome org,Christophe Fergeau <teuf users sourceforge net>,Sebastian Wilhelmi <wilhelmi ira uka de>
- Subject: Re: ORBit2 threading patches ...
- Date: 10 Feb 2003 09:10:17 +1300
Hi Michael,
I didn't read the patch in any great detail, but it looks really good -
very clean indeed.
Just a couple of typically unhelpful comments :-)
* I don't like the idea of extending the ThreadPolicy enum - just out
of pure spec lovery. I'd suggest something like
ORBit_Adaptor_set_threading_hint (adaptor, THREAD_PER_OBJECT);
and the hint would only be honoured with ORB_CTRL_MODEL.
* Also, I wouldn't change the default policy list - just interpret
ORB_CTRL_MODEL with no hint as single threaded ...
Anyway, good stuff :-)
Cheers,
Mark.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]