Re: Ball of string -> g_return_* macros in static functions - lots of them :(

[John Rice <John Rice Sun COM>]

Ahh yep grep is grand but wouldn't LXR be much better? Thought bonsai only allows you to search the change logs and doesn't give the type of internal cross referencing of the code that LXR does.

On Gnome.org used to be a link to one but doesn't seem to be functional [http://cvs.gnome.org/lxr/]. I'm just using jedit with the ctags plugin myself, but its limited to the modules I've grabbed from cvs, so an LXR against the nightly builds and one against the last stable release would be great.

Agreed we need more grunt work done on the g_return*() guard macros - I'll see if I can volunteer anyone to do it ;)

On the dtrace tidbits, bit snowed under at the minute, but planning to get a good blast at this at the end of November when I'm over in the US with a few other folks. I'll blog on all the profile and investigation results then I get out from under the current mountain :)

JR

Federico Mena Quintero wrote:

On Mon, 2005-10-17 at 17:37 +0100, John Rice wrote:
  

So what is the best way to help the maintainers fix this throughout
the stack?
    

grep is a good start ;)

Kjartan Maraas was going through several of the core modules to look for
places where g_return*() is used inside static functions.  We need more
people who will do the grunt work of finding those places.

On an unrelated note, do you have any dtrace tidbits to share with us?
Got some nice global profiles of the desktop, perhaps? :)

  Federico