Re: [Planner Dev] Advanced link tasks version 3.

[Richard Hult <richard imendio com>]

On ons, 2004-04-21 at 07:44 +0100, lincoln phipps openmutual net wrote:

> >>+++ src/planner-task-tree.c 20 Apr 2004 02:23:25 -0000
> >>@@ -36,6 +36,7 @@
> >>#include <gtk/gtkiconfactory.h>
> >>#include <gtk/gtkstock.h>
> >>#include <gtk/gtkmessagedialog.h>
> >>+#include <gtk/gtk.h>
> > 
> > 
> > We try to include just the necessary h files since it will slow down
> > compilation considerably to include the whole thing.
> 
> This is needed for something like the GTK_OPTION_MENU / GTK_BUTTON
> etc. I'll remove and see where it faileds and mark that in the comments.

Try to include the exact file instead (gtk.h includes all the gtk header
files), so it should be something like gtk/gtkoptionmenu.h or so.

> >>- MrpTask   *target_task;
> >>+ MrpTask   *target_task = NULL ;
> > 
> > 
> > Is the assignment necessary here (not obvious when just looking at the
> > patch), also there's a stray space there.
> 
> Without it the compiler complains of possible use of target_task
> before assignment (because target_task is used inside an if () I
> think) so this fixes compiler warning message.

OK

> I guess I'll therefore have to do,
> 
> list = planner_task_tree_get_selected_tasks (tree);
> count = g_list_length (list);
> ...
> g_list_free list);

Yep

> I was hoping to shortcut :) - ah wants a garbage collector :)

Me too ;)

> >>+++ src/planner-task-tree.h 20 Apr 2004 02:23:25 -0000
> >>@@ -50,6 +50,30 @@ struct _PlannerTaskTreeClass
> >>GtkTreeViewClass  parent_class;
> >>};
> >>+typedef struct {
> >>+ MrpProject *project;
> >>+
> >>+ GtkWidget  *link_relations; /* The relationship between tasks was
> >>link_relation */
> >>+ GtkWidget  *lag_text; /* The lag (+/- value) */
> >>+ GtkWidget  *label_mode; /* the Mode text (we need this to hide it)
> >>*/
> >>+ GtkWidget  *radiobutton_mode_c; /* This means cascade (n:n+1)*/
> >>+ GtkWidget  *radiobutton_mode_fo; /* ""   ""  fan-out (1:n)    */
> >>+ GtkWidget  *radiobutton_mode_fi; /* ""   ""  fan-in (n:last)  */
> >>+ GtkWidget  *radiobutton_direction_d; /* The direction d means
> >>downwards (visually) */
> >>+ GtkWidget  *radiobutton_direction_u; /* ""     ""     u means
> >>upwards (visually)  */
> >>+} PlannerLinkDialogData;
> > 
> > 
> > This should only sit in the c-file, it's just private data, right? And
> > the type could then be just LinkDialogData.
> 
> Its used by the planner-task-link-dialog.c too so I put it into the
> .h file where it was first used.

Hm, it should be possible to make it internal to the link dialog only,
right?

> Cool - I'll focus back on the Multi-task edit dialog and the project
> phase undo/redo first as thats 0.12 (and this was 0.13).

Great!

Thanks,
Richard

-- 
Imendio HB, http://www.imendio.com/