Re: [Planner Dev] Patch to add an abstraction layer between Planner and GConf

[Jani tiainen <redetin luukku com>]

lincoln phipps openmutual net wrote:

> Mikael Hallendal wrote:
>
> > Hi,
> >
> > Here is a patch to make an abstraction layer between the application and
> > GConf. The idea is to have planner-conf.h as a common header file and
> > planner-conf-gconf.c and planner-conf-windows.c that implements the
> > functions in the header file. At compile time either planner-conf-
> > gconf.c or planner-conf-windows.c is linked in to provide the
> > implementation of the functions.
>
>
> Could the file name be planner-conf-mswindows.c or planner-conf-mswin32.c
> so its clearer its MS Windows. This makes grepping for the strings
> easier as Windows is *so* generic ;)

Well, since GNOME (and most of all other sources) use usually uses 
"win32" to mark MS Windows, I would give vote for "win32"

(Like libgtk-win32-2.0-0.la)

> > The API mimics GConf and I've only added the functions needed so far,
> > for example:
> >
> > gboolean foo = planner_conf_get_bool ("/general/last_dir", error);
> >
> > So, keep in mind that you don't have to add "/apps/planner", that is
> > added within planner-conf-gconf.c.

Nice thing indeed, unfortunately it doesn't resolve indirect need for 
gconf in gnome-vfs and libgsf (IIRC).

--

Jani Tiainen