Re: [Planner Dev] Task dialog undo

["lincoln phipps openmutual net" <lincoln phipps openmutual net>]

How about the

Index: libplanner/mrp-task.c
===================================================================
RCS file: /cvs/gnome/planner/libplanner/mrp-task.c,v
retrieving revision 1.4
diff -u -b -B -p -r1.4 mrp-task.c
--- a/libplanner/mrp-task.c	25 Apr 2004 22:11:35 -0000	1.4
+++ b/libplanner/mrp-task.c	5 Jun 2004 00:13:56 -0000
@@ -549,6 +549,8 @@ task_set_property (GObject      *object,
 		
 		if (priv->percent_complete != i_val) {
 			priv->percent_complete = i_val;
+
+			g_object_notify (G_OBJECT (task), "percent_complete");
 			changed = TRUE;
 		}
 		
Alvaro del Castillo wrote:

> Hi!
>
> El vie, 04-06-2004 a las 05:12, lincoln phipps openmutual net escribió:
>
> > > The prob is that spinbutton field doesn't get updated its contents. For
> > > example, if I change the complete to "20" and then undo it so the value
> > > in the MrpTask goes to "0". the value that the spinbutton shows is "20"
> > > :(
> >
> > I noticed something similar in the project properties dialog.
> > Can you try this....If you move a mouse-over or cause a window paint
> > does it update (like move the dialog title bar to cause it to redraw )?.
>
>
> No, it doesn't.
>
> I have tried to mouse over, and focus in.
>
> Also, I have rolled in/out the task editor window and no refresh for the
> complete field.


OK how about...


Index: libplanner/mrp-task.c
===================================================================
RCS file: /cvs/gnome/planner/libplanner/mrp-task.c,v
retrieving revision 1.4
diff -u -b -B -p -r1.4 mrp-task.c
--- a/libplanner/mrp-task.c	25 Apr 2004 22:11:35 -0000	1.4
+++ b/libplanner/mrp-task.c	5 Jun 2004 00:13:56 -0000
@@ -549,6 +549,8 @@ task_set_property (GObject      *object,
 		
 		if (priv->percent_complete != i_val) {
 			priv->percent_complete = i_val;
+
+			g_object_notify (G_OBJECT (task), "percent_complete");
 			changed = TRUE;
 		}
 		
@@ -559,6 +561,8 @@ task_set_property (GObject      *object,
 		
 		if (priv->priority != i_val) {
 			priv->priority = i_val;
+			
+			g_object_notify (G_OBJECT (task), "priority");
 			changed = TRUE;
 		}
 		


He he...It doesn't actually raise a notify signal ;)  I guess we
complain to MrProject people huh ?.

Also in planner-task-dialog.c the actual g_signal_handlers_block_by_func
should it match the actual function its in ? If so that need to
change too e.g....

Index: src/planner-task-dialog.c
===================================================================
RCS file: /cvs/gnome/planner/src/planner-task-dialog.c,v
retrieving revision 1.12
diff -u -b -B -p -r1.12 planner-task-dialog.c
--- a/src/planner-task-dialog.c	4 Jun 2004 05:27:36 -0000	1.12
+++ b/src/planner-task-dialog.c	5 Jun 2004 00:13:59 -0000
@@ -876,14 +878,14 @@ task_dialog_task_complete_changed_cb (Mr
 	g_object_get (task, "percent_complete", &complete, NULL);
 	
 	g_signal_handlers_block_by_func (data->complete_spinbutton,
-					 task_dialog_complete_changed_cb,
+					 task_dialog_task_complete_changed_cb,
 					 data);

 	gtk_spin_button_set_value (GTK_SPIN_BUTTON (data->complete_spinbutton),
 				   complete);
 	
 	g_signal_handlers_unblock_by_func (data->complete_spinbutton,
-					   task_dialog_complete_changed_cb,
+					   task_dialog_task_complete_changed_cb,
 					   data);
 }



/Lincoln.

> Cheers
>
>
> > > Cheers 
> > >
> > >
> > >
> > > > /Richard
> > >
> > >
> > >
> > > ------------------------------------------------------------------------
> > >
> > > _______________________________________________
> > > Planner-dev mailing list
> > > Planner-dev lists imendio com
> > > http://lists.imendio.com/mailman/listinfo/planner-dev
> >
> > _______________________________________________
> > Planner-dev mailing list
> > Planner-dev lists imendio com
> > http://lists.imendio.com/mailman/listinfo/planner-dev
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Planner-dev mailing list
> Planner-dev lists imendio com
> http://lists.imendio.com/mailman/listinfo/planner-dev