Re: [Planner Dev] New patch to solve link arrows prob in gantt with undo/redo



On ons, 2004-05-12 at 07:41 +0000, Alvaro del Castillo wrote:
> Hi guys!
> 
> I have added a patch to bugzilla in order to solve the bug:
> 
> http://bugs.gnome.org/show_bug.cgi?id=141346
> 
> If everything is ok, I will commit it.

You are leaking GErrors, I think.

We also need to be very careful when/if doing this change. 

Only the root of a subtree emitted the "removed" signal before, and the
rest of the code takes that in consideration, i.e. by traversing the
tree itself and removing canvas items, disconnecting signals, etc. If we
change it to emit the signal for the while subtree, we probably need to
change all of the other code. Did you test this patch with a complex
project with subtrees, links, resource allocations?

/Richard

-- 
Imendio HB, http://www.imendio.com/




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]