Re: [Planner Dev] Prop. for new feat. - second patch overview

[Richard Hult <richard imendio com>]

Hi,

Kurt Maute skrev:
> On Wed, 2006-02-01 at 21:55 +0100, Matteo Nastasi wrote:
>
> > > - I must add a view option to see/unsee the non working days.
> > Accomplished.
>
> great!
>
> > > - Investigation about graphical clipping for gdk/X.
> > Ok, gdk verify nothing about X overflow, my proposal is a set of draw
> > functions with the same semantic of related gdk_draw_* functions and
> > with an automatic clip on coordinate and dimension arguments.
> >
> > Some like:
> > vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
> > // Trim the value to short int work space */
> > #define TRSH(a) ((int)((a) < 0xffff ? (short int)0xffff : \
> >                               ((a) > 0x7fff ? (short int)0x7fff : (a))))
> >
> > #define draw_cut_rectangle ((a),(b),(c),(d),(e),(f),(g))    \
> >         gdk_draw_rectangle ((a),(b),(c),TRSH(d),TRSH(e),TRSH(f),TRSH(g))
> >
> > #define draw_cut_line ((a),(b),(c),(d),(e),(f))  \
> >         gdk_draw_line ((a),(b),TRSH(c),TRSH(d),TRSH(e),TRSH(f))
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > or inline functions if you prefer.
>
> I believe inline functions are the norm in Planner... Richard - what's
> your take on this one?

Using macros is fine by me. I haven't really thought about what they do 
though. We probably need some comments in the code for that.

> > - for "rectangle" and "layout" this choise work well, 
> > - for "line" there is the restriction to draw horizontal or vertical lines
> >  (otherwise you must use a much more sophisticate clip algorithm); in
> >  planner-gantt all lines are horiz or vert.
> > - for "polygon" we can continue to use the native function and an explicit check 

The small polygons we should draw shouldn't risk getting drawn that big 
anyway...

> > > - Add #ifdef to disable vampire (or the name that we want
> > >   definitively to use for it)
> > Accomplished: I add the --enable-vampire param (default = no) into ./configure.in
> > and the related WITH_VAMPIRE macro.
>
> How about --enable-priority-scheduling  ??

Or --enable-simple-priority-scheduling to emphasize that it's not the 
"real" thing.

/Richard

--
Imendio AB, http://www.imendio.com/