On Sun, Jun 14, 2009 at 06:10:57PM +0200, Alexandre Franke wrote: > Could you split the patch in smaller ones? It would be better to have > one commit per change. This allows to find problems more easily > afterwards (using git bisect for instance) and newcomers can have a > better understanding of the commit history. Also it makes it easier to > review the patches. I've not looked at it in detail yet, but I thought the changes to existing Planner files seem to be limited. The big stuff is in new files. I'll try to start my review tomorrow. Maurice. -- Maurice van der Pot Gentoo Linux Developer griffon26 gentoo org http://www.gentoo.org Gnome Planner Developer griffon26 kfk4ever com http://live.gnome.org/Planner
Attachment:
pgp2UIxv4IvaE.pgp
Description: PGP signature