Re: [PATCH 00/16]fix warning: variable 'priv' set but not used

[Tinggong Wang <wangtinggong gmail com>]

on Fri, 14 Oct 2011 06:47:40PM +0200 Alexandre Franke (alexandre franke gmail com) wrote:
> On Fri, Oct 14, 2011 at 3:02 AM, Tinggong Wang <wangtinggong gmail com> wrote:
> > I think they are trivial fixes, and small patches are more easy to review,
> > so i follow the rule in this page:
> >  http://live.gnome.org/Planner/Development
> 
> I think that for such a consistent set of modifications, one patch is
> easy enough to be reviewed. Splitting makes only sense when there are
> several logical steps involved.
more clear now, Thanks! 
It's great to add this rule to the 'Submitting patches' section in wiki.  

> 
> > I'll open a bug on bugzilla soon, and attach one patch for this warning.
> 
> Thanks a lot. Patch reviewed, applied and pushed to master. Bug mark
> as resolved (fixed).
> 
> > I'm sorry for my rude behavior, i am really don't know who should be the
> > recipient, so i send to the people in AUTHORS.
> 
> I really didn't mean to be hurtful and I hope it was ok. I just wanted
> to explain the right way so that you know how to do in the future. :-)
> 
> People in AUTHORS are the ones that made big contributions at some
> point, but are not necessarily maintaining the software anymore.
> There's a planner.doap file with maintainer fields for the people
> currently taking for of the project.
this info also helpful for newbies to submit patch. 
may be it worth on the Development page in wiki.

Thanks!

--
Tinggong
2011-10-16


> 
> > i got it now, thanks for your help :)
> 
> Thanks for your understanding and contribution.
> 
> -- 
> Alexandre Franke
> _______________________________________________
> planner-dev-list mailing list
> planner-dev-list gnome org
> http://mail.gnome.org/mailman/listinfo/planner-dev-list