Re: A consistency patch (Bug 781516)
- From: Alexandre Franke <afranke gnome org>
- To: Andrew Miloradovsky <miloradovsky gmail com>
- Cc: Planner-Dev-List <planner-dev-list gnome org>
- Subject: Re: A consistency patch (Bug 781516)
- Date: Fri, 21 Apr 2017 12:51:11 +0200
On Fri, Apr 21, 2017 at 12:34 PM, Andrew Miloradovsky
<miloradovsky gmail com> wrote:
Hi,
Hi,
I've prepared a fresher version of Planner's port to Nixpkgs, based on
the master branch and not on the release:
- https://github.com/amiloradovsky/nixpkgs/tree/planner
Please let me know, If there's something to correct before opening the
pull request.
The fact that you use the term “pull request” has me worried. You know
by now that we don’t use github for our workflow, so I hope you don’t
plan on using a github pull request. The correct way would be to file
a bug *right now* (i.e. no need to wait until your code is ready), and
in this report provide info about your commits. You can attach patches
so that we review them there, or if it really is an issue you can give
the address to your branch someplace else. In any case you shouldn’t
ask for a “pre-review” (‘let me know if there’s something to correct
before submitting”).
- https://bugzilla.gnome.org/show_bug.cgi?id=781516
and I'm not sure if the developers were informed of it's existence or
simply are busy.
This implies that your patch that was submitted only yesterday should
have been reviewed by now. This is quite an unreasonable expectation.
I am fully aware of it and it’ll get reviewed.
--
Alexandre Franke
GNOME Hacker & Foundation Director
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]