Re: [Resent] Code freeze break request for evolution

[Frederic Peters <fpeters gnome org>]

Matthias Clasen wrote:

> On Fri, Apr 1, 2011 at 10:37 AM, Kjartan Maraas
> <kjartan maraas gmail com> wrote:
> > Hi.
> >
> > I've been chasing a bug in evolution where translations stopped working
> > correctly after opening the plugin dialog. Finally tracked it down to a
> > couple plugins that were calling bindtextdomain() with the wrong
> > translation domain (it wasn't set because of a bug in Makefile.am).
> >
> > The patch removes the calls to bindtextdomain() and friends from the
> > plugins since they should just be inheriting the translation domain from
> > main() anyway since they are distributed together with the application
> > and are dlopened by evolution itself.
> 
> Looks correct to me. Nice detective work !

Yeah; second approval.


        Frederic