Re: [Rhythmbox-devel] more mp3 handling fixes

[Bastien Nocera <hadess hadess net>]

On Mon, 2003-11-17 at 05:38, Colin Walters wrote:
> On Sun, 2003-11-16 at 18:35, Bastien Nocera wrote:
> > Heya,
> > 
> > It didn't in any one bugzilla anymore, so I'm posting it here.
> > 
> > - Special-cases wave files (doesn't go as deep if they're waves, to
> > avoid false positives, bz # 124298)
> > - Discard empty tag fields, fixes metadata reading from emusic.com files
> > (bz # 121841)
> > - implement TLEN (Track Length) tag from id3v2
> 
> Great!  I just have one minor quibble:
> 
> mp3-stream-info-impl.c: In function `MP3_stream_info_impl_get_length_from_tag':
> mp3-stream-info-impl.c:201: warning: unused variable `ms'
> 
> Please make sure patches compile with -Wall -Werror :)
> The patch queue manager I plan to set up in the near future will be
> enforcing this...

Oops, didn't see that one...

> > Please test and apply. Don't forget to close the bugs when done ;)
> 
> Applied, thank you!
---
Bastien Nocera <hadess@hadess.net> 
You don't have to be mad to work here, but you do have to be on time,
well presented, a team player, customer service focused and sober!!