Re: [Rhythmbox-devel] Patch to fix segfault on nonexistent"/state/selected_source" gconf key



How can it get NULL ? It has a value in the schema, is it possible to
mess things up and end up with an empty CONF_STATE_SELECTED_SOURCE ?
Moreover g_return_if_fail doesn't return if things are compiled with
G_DISABLE_CHECKS defined.

Christophe


Le jeu, 04/03/2004 à 18:24 -0600, Jeffrey Yasskin a écrit :

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> 
> If nobody has any objections to this patch, I'll commit it tomorrow:
> 
> (Stupid email clients wrapping lines: the (CONF...) should be on the
> same line.)
> 
> - --- orig/shell/rb-shell.c
> +++ mod/shell/rb-shell.c
> @@ -2345,6 +2345,7 @@
> ~        GList *tmp;
> 
> ~        internalname = eel_gconf_get_string (CONF_STATE_SELECTED_SOURCE);
> +       g_return_if_fail (internalname);
> 
> ~        for (tmp = shell->priv->sources; tmp ; tmp = tmp->next) {
> ~                const char *tmpname;
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.4 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
> iD8DBQFAR8i+fjbRRQT0l5URAkqTAJ0R/Cxjy7mOPW62FRCDCaMaHfVlewCfTGl2
> XJksP/HwtcE9HoAyNtE8cJY=
> =gnNK
> -----END PGP SIGNATURE-----
> _______________________________________________
> rhythmbox-devel mailing list
> rhythmbox-devel@gnome.org
> http://mail.gnome.org/mailman/listinfo/rhythmbox-devel

Ceci est une partie de message=?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]