Re: [Rhythmbox-devel] Rhythmbox 0.9

[Jonathan Matthew <jonathan kaolin hn org>]

On Mon, Nov 08, 2004 at 12:39:14AM -0600, Michael Messmore wrote:
> I'm a bit curious to see how things are going with the 0.9 branch, and
> decided to check out a copy from the main arch repository.  I'm
> running Gentoo/amd64, so I don't know if its a 64-bit issue or not,
> but compilation died for me in rb-recorder-gst.c.
> 
> rb-recorder-gst.c: In function `rb_recorder_burn':
> rb-recorder-gst.c:1101: warning: long long int format, gint64 arg (arg 5)
> rb-recorder-gst.c:1101: warning: long long int format, gint64 arg (arg 6)
> 
> If this is a 64-bit issue, then consider this a bug note ;).

It certainly looks that way to me.  Current 0.9 branch (plus some bits
I'm working on..) compiles fine for me on my primitive archaic 32-bit
machine.  Not being terribly familiar with glib types, or the sizes of
various types in 64-bit code, I'd be inclined to just add casts in
there.  Trivial patch below (obviously not tested), if anyone finds that 
easier than doing it themselves.

-jonathan.

--- rb-recorder-gst.c.orig      2004-10-19 19:45:32.000000000 +1000
+++ rb-recorder-gst.c   2004-11-09 00:03:54.000000000 +1000
@@ -1097,8 +1097,8 @@
                              RB_RECORDER_ERROR_GENERAL,
                              _("This playlist is %lld minutes long.  "
                                "This exceeds the %lld minute length of the media in the drive."),
-                             tracks_length / 60,
-                             media_length / 60);
+                             (long long int)(tracks_length / 60),
+                             (long long int)(media_length / 60));
                 return FALSE;
         }