Re: [Rhythmbox-devel] Rhythmbox archive

[Bastien Nocera <hadess hadess net>]

On Tue, 2005-06-07 at 11:19 +0200, Christophe Fergeau wrote:
> Le mardi 07 juin 2005 à 00:10 +0100, Bastien Nocera a écrit :
> > A few updates.
> > 
> > Christophe, could you double-check my GCC-4.0 fixes commit, especially
> > in the rhythmdb/ directory, I think a few mistakes might have slipped
> > in.
> 
> Sure, do you have a diff handy, or will I have to time-travel to the
> stone age and fight with CVS to get a diff for this commit ? ;)

I should have kept something around, I'll dig it from CVS in a minute.

> > > patch-11
> > >     don't attempt to build dbus remote interface with new dbus
> > 
> > We should have something similar for HAL as well.
> 
> Did you commit this?

Nope, not yet, I wanted to be able to test it first.

> > > patch-32
> > >     fix split sentences in po files (#166737)
> > 
> > This is missing some comments for the translators.
> 
> What kind of comments do you think it needs? Something saying that the %
> s in the translated string will be replaced with a number? Imo this
> shouldn't confuse translators too much.

Ha, thought there was some other data in there. I'll commit it in a
minute.

> > 
> > > patch-36
> > >     show entry view popup on shift-f10 or menu key press
> > 
> > That doesn't work if the treeview isn't focused first.
> > 
> 
> So not committed for now? (I'm asking so that I don't miss already
> committed patches when I clean up the patch repo)

Not committed, needs-work.

---
Bastien Nocera <hadess hadess net>