On Thu, 2005-10-20 at 21:50 -0500, Paul Kuliniewicz wrote: > The recently-enhanced D-Bus interface doesn't play nicely with the > recently-added podcast support in CVS. When a D-Bus client invokes > getSongProperties, the rb_shell_get_song_properties function is called. > This function tries to read every property in the specified RhythmDB > entry. When it tries to read properties related to podcasts, > rhythmdb_entry_get_(string|ulong) dereferences a null pointer > (entry->podcast) and causes Rhythmbox to crash. > > The attached simple patch modifies rhythmdb_entry_get_string and > rhythmdb_entry_get_ulong to check if entry->podcast is null before > dereferencing it. > > The patch seems to fix the problem, at least with a few minutes' worth > of testing. Thanks, it also fixed the crash I was just seeing. I've committed it to cvs. Cheers, James "Doc" Livingston -- It is by caffeine alone that I set my mind in motion. It is by the beans of java that the thoughts acquire speed, the hands acquire shaking, the shaking becomes a warning. It is by caffeine alone that I set my mind in motion.
Attachment:
signature.asc
Description: This is a digitally signed message part