Re: [Rhythmbox-devel] Last.fm Integration Patch #5
- From: Jonathan Matthew <jonathan kaolin hn org>
- To: rhythmbox-devel gnome org
- Subject: Re: [Rhythmbox-devel] Last.fm Integration Patch #5
- Date: Tue, 20 Sep 2005 11:11:36 +1000
On Tue, Sep 20, 2005 at 12:42:41AM +1000, Jonathan Matthew wrote:
> On Mon, Sep 19, 2005 at 11:57:34PM +1000, Jonathan Matthew wrote:
>
> > There were a few leaks and other types of badness in there, which I've
> > fixed: http://j.kaolin.hn.org/rhythmbox/rb-audioscrobbler.c
>
> .. and there was a small matter of that version being completely broken,
> which now fixed. Audioscrobbler appears to be down at the moment, so
> I'm not completely sure it all works.
Also, I don't know why I didn't notice before, but the g_object_set at
the bottom of rb_shell_select_source should be removed. The
shell-player instance never changes, and the property on the
audioscrobbler object is construct-only now.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]