Re: [Rhythmbox-devel] DACP (iTunes remote) support added

["W. Michael Petullo" <mike flyn org>]

> The following stub entry in libdmapsharing to just say we don't
> have covers (rather than not handling the request at all) seems
> to solve the stale cover issue I was seeing in the Remote app:
> 
> diff --git a/libdmapsharing/dmap-share.c b/libdmapsharing/dmap-share.c
> index 1c714df..be3ed1f 100644
> --- a/libdmapsharing/dmap-share.c
> +++ b/libdmapsharing/dmap-share.c
> @@ -1774,6 +1774,12 @@ _dmap_share_databases (DMAPShare *share,
>                         path,
>                         query,
>                         context);
> +       } else if (g_str_has_prefix(rest_of_path, "/1/groups/") &&
> +                  g_str_has_suffix(rest_of_path, "/extra_data/artwork")) {
> +               /* We don't yet implement cover requests here, say no cover */
> +               g_debug ("Assuming no artwork for requested group/album");
> +               soup_message_set_status (message, SOUP_STATUS_NOT_FOUND);
> +               return;
>         } else {
>                 g_warning ("Unhandled: %s\n", path);
>         }
> 
> Clearly the libdmapsharing API must be extended, presumably in
> the same way as the dacp_player_now_playing_artwork function
> is called for the /ctrl-int/1/nowplayingartwork request to give a
> filename back - I guess we need to add a dmap_group_artwork
> function (or some such name) which will be passed the group
> identifier, and return a filename,

Applied to libdmapsharing Git master. Please test.

-- 
Mike

:wq