Re: [Rhythmbox-devel] Ratings in notifications.

[Utkarsh Upadhyay <musically ut gmail com>]

Hi all,

This is a follow-up to the mail below.

The first feedback I got was that the ratings were not immediately updated after changing them via the notification.

Now the notification is updated as soon as the ratings are altered via the added buttons.

The modified patch is here: https://gist.github.com/2056511

Also, I have put it up for review on Rietveld: http://codereview.appspot.com/5847055/

Any thoughts?

~

Utkarsh.

On Tue, Mar 6, 2012 at 9:45 AM, Utkarsh Upadhyay <musically ut gmail com> wrote:

Hi all,

I have been working on a patch for the Notification plugin to add rating buttons to the Notification. 

I wanted to put the idea as well as the patch up for an initial review.

The patch does the following:

1. Adds buttons to Rate Up and Rate Down the currently playing song in the Notification bubble.

2. Adds a Preference UI for the Notification plugin from where the ratings buttons can be enabled/disabled.

3. Adds schema for saving the setting.

The buttons I am using for rating songs up and down are 'go-up' and 'go-down' stock icons for lack of a better choice. 

Nirbheek has pointed out this UI inconsistency already and I am open to suggestions of how to deal with it.

I have posted screen-shots and a short video demonstration of the plugin on my blog here: http://musicallyut.blogspot.in/2012/03/rate-songs-in-notifications-with.html

The patch is also available from here: https://gist.github.com/1978836

Thanks!

~

musically_ut