Re: SAWFISH and XFCE4

[Willy Gardiol <willy gardiol org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


You are right, i patched the code in xfce4 and fixed the problem, i have sent 
the modified patch to the xfce4 mailing list to have it inserted in the cvs 
branch.

Why have they copied libwnck functionalities ???

thank for help!


Alle Sunday 12 September 2004 01:12, GSR - FR ha scritto:
> willy gardiol org (2004-09-12 at 0011.36 +0200):
> > No, i have checked, my libwnck already includes that patch... that is not
> > the reason.
> >
> > LibWNCK is libwnck-2.6.2.1, and the patch is already included as i can
> > see.
>
> XFCE also has code that does pager tasks (quick download and grep),
> are you sure it does all perfectly? I saw in the file
> libxfcegui4-4.0.6/libxfcegui4/netk-pager.c a call like:
>
> netk_screen_move_viewport (pager->priv->screen, viewport_x, viewport_y);
>
> after a
>
> workspace_at_point (pager, event->x, event->y, &viewport_x, &viewport_y);
>
> which seems pretty similar to the libwnck status previously to the
> patch linked in the bug I pointed. That is, no modification of coords
> to make all be "non fractional screens".
>
> And greeping for wnck I only get
>
> AUTHORS:libxfcegui4 includes libwnck by Havoc Pennington <hp redhat com>
>
> so it does not seem to use it by "#include", which could mean that
> bugs fixed in one place are not fixed in another. You could verify by
> checking which libs it requires (package, ldd or whichever you can
> think of as good method).
>
> It could also be a completly misreading of code on my side (non XFCE
> coder or user, just quick look at the issue). Up to you to decide if
> you investigate more, just patch netk-pager.c or insist in "sawfish is
> broken".
>
> GSR

- -- 

! 
 Willy Gardiol - willy gardiol org
 www.gardiol.org
 +39 3492800983
 Use linux for your freedom.

   "Cari fratelli dell'altra sponda
    cantammo in coro giù sulla terra
    amammo in cento l'identica donna
    partimmo in mille per la stessa guerra.

    Questo ricordo non vi consoli
    quando si muore si muore soli."

	(Il Testamento, Fabrizio De Andrè)


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBRBVrQ9qolN/zUk4RAs9wAKCFkFmCChtTKZpXCrm2oaCDGMeTLgCfcd6c
hKHfvg/7kWIoJkrBpi+1EQk=
=q1fO
-----END PGP SIGNATURE-----