Re: Why does sawfish draw windows as inactive while other wms draw them as active when a menu pops up?

[Anton Kazennikov <kazennikov nntp gmail com>]

Harald van Dijk <truedfx gentoo org> writes:

> Sorry that I haven't posted this earlier, but this patch (from -mmc)
> appears to make KDE's menus behave properly:
>
> +++ sawfish/src/events.c
> @@ -955,11 +955,15 @@
>      Lisp_Window *w = find_window_by_id (ev->xfocus.window);
>      if (ev->xfocus.detail == NotifyPointer)
>  	return;
> +    if (ev->xfocus.mode == NotifyGrab || ev->xfocus.mode == NotifyUngrab)
> +	return;
>      if (w != 0 && ev->xfocus.detail != NotifyInferior)
>      {
>  	if (focus_window == w)
>  	{
> -	    focus_window = 0;
> +	    if (ev->xfocus.mode == NotifyNormal || ev->xfocus.mode == NotifyWhileGrabbed)
> +		focus_window = 0;
> +
>  	    report_focus_change (w);
>  	}
>  
> Could someone more familiar with sawfish internals say whether this
> patch is sane?

I wrote a similar patch some months ago. It works perfectly and solve all
problems with qt applications.

-- 
With best regards,
Anton Kazennikov.  mailto:kazennikov[at]mirea.ru ICQ# 98965967