Re: Title changes and titlebar updates

[Harald van Dijk <truedfx gentoo org>]

On Mon, Jan 21, 2008 at 11:17:19PM +0100, Harald van Dijk wrote:
> Hi all,
> 
> I've installed sawfish 1.3.2, but I seem to be having a problem with the
> netwm patch. When using the crux theme, the blue left part of the title
> bar is supposed to end after the title. This still mostly works, but
> when the title changes, the titlebar background does not get updated,

The problem is that Crux does

  (call-after-property-changed 'WM_NAME ...)

and because of

  /* No point in updating the rest if we have the _NET ones. They won't
     be used anyways. */
  if (w->net_name != Qnil)
    return FALSE;

from src/events.c (new with the netwm patch) it no longer gets executed.
I believe this can simply be removed, and the attached patch does so.
With this, sawfish updates the title bar properly again.

Of course, it's possible to update the theme to also check the other
properties, but I don't think that should be necessary.

--- sawfish-1.3.2/src/events.c.orig	2008-01-22 21:11:47.000000000 +0100
+++ sawfish-1.3.2/src/events.c	2008-01-22 21:11:59.000000000 +0100
@@ -550,11 +550,6 @@
 	}
     }
   
-  /* No point in updating the rest if we have the _NET ones. They won't
-     be used anyways. */
-  if (w->net_name != Qnil)
-    return FALSE;
-  
   if (xproperty.atom == XA_WM_NAME)
     {
       if (str == Qnil)