Re: [Patch] apps-menu filtering

[Jeremy Hankins <nowan nowan org>]

Matthew Love <matth love gmail com> writes:

> Ok, see attached patch (diff to current git).  
> The way categories are sorted has changed.  There is a new variable
> 'apps-menu-associate-categories, which can be set to nil, which will use
> the categories directly from the desktop file in the menu, which means 
> one could change the categories as they like through filters.  
>
> By default, the categories are associated with the 'master category list',
> so one could still change the location of entries throughout those with
> filters as well, though now it accepts multiple categories, and will
> distribute the entry between all associated categories.

This works for me, thanks!  One thing, though: would it make sense to
split the entries (for the categories) before the filter is run?  That
would simplify modifying categories, since you'd use "equal" instead of
"string-match", and just set a new Category rather than string-replace.
That'd mean that the filters would run after
fdo-associate-categories-filter, would that cause problems?

The only other thing is that it might make sense to run fdo-check-exile
(or something similar) after filtering, to catch errors in users'
filters.  E.g., if I set the category to something silly (e.g., "") that
currently just wipes out that entry, without producing any kind of
warning message to help me track down the problem.

Thanks!

-- 
Jeremy Hankins <nowan nowan org>