Re: [Shotwell] Map Widget Update

[Jens Georg <mail jensge org>]

Hey,

> Given the new Shotwell maintainer Jens, I was motivated to pick up the
> work on the map feature: https://bugzilla.gnome.org/show_bug.cgi?id=716
> 987
>
> The current state can be cloned from my libchamplain branch on github:
> https://github.com/abrauchli/shotwell.git
>
> What changed since the last state in the bug report:
> - Rebased on current master
> - Copyright reassigned to SFC

To my understanding there is no need to assign copyright to the SFC you
can just keep it.

> - Lock state on the map to avoid accidentally setting a position
>   (by dropping an image on the map)
> - Group nearby markers together, I also created a new icon for this
>
> I'd be happy if someone could test this on a larger collection and be
> interested if there's a performance impact. My tests have so far been
> on smaller collections.

How big?

> Of course a code review is most welcome too.

I will try to have a look this week-end.

> I'm confident that we now have enough features for a stable Shotwell
> release with the map widget. Jens, let me know if you feel that there's
> anything crucial that's missing and that'd cause you to reject a patch.

One thing that comes to my mind is that the (SVG) images you use should 
have a
proper license (with "proper" I mean one that can be used in Debian[1] 
such
as CC-BY-SA [34].0) If we cannot guarantee this, things can get very 
annoying.

[1] https://wiki.debian.org/DFSGLicenses