Re: [Shotwell] Adjust photo in fullscreen

[Jerome Verleyen <jerome verleyen fr>]

Dear jens

Sorry to answer so late. I'm outside all the day.

I do the modification you explain me:
tool_window.set_transient_for(get_container());

But i get back the same compilation issue as before:

vapi/libgdata.vapi:2657.3-2657.9: warning: attribute `Version' never used
    [Version (since = "0.7.0")]
     ^^^^^^^
vapi/libgdata.vapi:2826.3-2826.9: warning: attribute `Version' never used
    [Version (since = "0.7.0")]
     ^^^^^^^
Compilation failed: 0 error(s), 72 warning(s)
Makefile:7313: recipe for target 
'plugins_shotwell_publishing_shotwell_publishing_la_vala.stamp' failed
make[2]: *** 
[plugins_shotwell_publishing_shotwell_publishing_la_vala.stamp] Error 1
make[2]: Leaving directory '/home/jerome/shotwell'
Makefile:7411: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/jerome/shotwell'
Makefile:1658: recipe for target 'all' failed
make: *** [all] Error 2

Regards

Le 27/02/2017 à 03:15, Jens Georg a écrit :
> > Compilation failed: 0 error(s), 72 warning(s)
> > Makefile:7361: recipe for target
> > 'plugins_shotwell_publishing_shotwell_publishing_la_vala.stamp' failed
> > make[2]: ***
> > [plugins_shotwell_publishing_shotwell_publishing_la_vala.stamp] Error
> > 1
> > make[2]: Leaving directory '/home/jerome/shotwell'
> > Makefile:7411: recipe for target 'all-recursive' failed
> > make[1]: *** [all-recursive] Error 1
> > make[1]: Leaving directory '/home/jerome/shotwell'
> > Makefile:1658: recipe for target 'all' failed
> > make: *** [all] Error 2
>
> That's odd.
>
>
> > What i do after is to checkout the version before the commit you 
> > comment out:
> >
> > $ git checkout a409642472f9609e470ed9216b944c0c87f47637
> >
> > And with this specific version compiled, the adjust menu appears
> > correctly. Your idea was correct...
>
> Thanks for testing. Can you also check if adding
>
> tool_window.set_transient_for(get_container());
>
> before tool_window.show_all() in PhotoPage.vala:2182 also fixes the 
> issue?


--
-- Jérôme
Quand un arbre tombe, on l'entend ; quand la forêt pousse, pas un bruit.
        (Proverbe africain)