Re: [PATCH 06/18] Fix ref leak with the iter_store in tny_camel_store_account.
- From: Rob Taylor <rob taylor codethink co uk>
- To: Philip Van Hoof <spam pvanhoof be>
- Cc: tinymail-devel-list <tinymail-devel-list gnome org>
- Subject: Re: [PATCH 06/18] Fix ref leak with the iter_store in tny_camel_store_account.
- Date: Sun, 31 Aug 2008 20:47:24 +0100
Philip Van Hoof wrote:
On Fri, 2008-08-29 at 17:42 +0100, Rob Taylor wrote:
Fix ref leak with the iter_store in tny_camel_store_account.
Not approved, why aren't you unreferencing priv->iter_store but instead
are you unreferencing store?
Not making sense to me ...
Hmm, good point, lets ignore this patch for now..
Rob
+
+ if (priv->iter_store) {
+ camel_object_unref (CAMEL_OBJECT (store));
+ }
camel_object_ref (CAMEL_OBJECT (store));
priv->iter_store = store;
---
libtinymail-camel/tny-camel-store-account.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
--
Rob Taylor, Codethink Ltd. - http://codethink.co.uk
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]