Re: Patch: avoid using PR_Cleanup

[Philip Van Hoof <spam pvanhoof be>]

Agree

Approved

On Fri, 2008-07-04 at 00:35 +0200, José Dapena Paz wrote:
> 	Hi,
> 
> 	This bug is simple. On shutting down camel, we were calling
> NSS_Shutdown and PR_Cleanup. With this, we remove PR_Cleanup, as it's
> not safe in complex applications (it does not warrant that other threads
> are running after removing the common threads control information in
> NSPR).
> 
> 	You can see more information here:
> 	https://bugzilla.mozilla.org/show_bug.cgi?id=54189#c1
> 
> 	All the camel based apps (modest, other tinymail based, evolution,
> evolution-data-server based, etc) can get the same issue and in fact
> there are crash reports very similar. Other apps as curl, or firefox, do
> not use PR_Cleanup at all, and this seems it was not really required.
> 
> Changelog entry:
> * libtinymail-camel/camel-lite/camel/camel.c:
>   Drop usage of PR_Cleanup on shutting down camel, as this is not safe,
>   nor required. This method is responsible for freeing the common
>   threads management code, including the lock that's accessed on the
>   crash in __nptl_deallocate_tsd.
> 
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be