Re: Patch: delayed refresh mode in folder list store

[Sergio Villar Senin <svillar igalia com>]

José Dapena Paz escribiu:
> 	Hi,
> 
> 	This patch adds a new mode to tinymail TnyGtkFolderListStore called
> "delayed refresh". This is for acting as an offline account to show fast
> cached folders, but then do a refresh to act as offline (this improves a
> lot the user experience, faster feedback). This patch also allows to
> detect better new remote folders.

My comments:

@@ -1385,6 +1385,49 @@ tny_camel_store_account_factor_folder_default
(TnyCamelStoreAccount *self, const

I think you have to protect the access to priv->managed_folders with the
factory_lock.

@@ -1477,11 +1520,13 @@ tny_camel_store_account_get_folders_default
(TnyFolderStore *self, TnyList *list

Shouldn't we call "_tny_camel_store_account_refresh_children" only if
refresh==TRUE ?

@@ -81,6 +81,29 @@ guint tny_gtk_folder_list_store_signals [LAST_SIGNAL];

I think you have to protect the access to self->first with the iterator_lock

@@ -466,6 +501,12 @@ tny_gtk_folder_list_store_on_constatus_changed
(TnyAccount *account, TnyConnecti

Why do you need to unset the flags?

@@ -651,6 +692,18 @@ tny_gtk_folder_list_store_add_i
(TnyGtkFolderListStore *self, TnyFolderStore *fo

Does this mean that everytime you add a new account, you're canceling
the refresh of the previous one? If accounts are added too fast you'll
end up refreshing only the most recent one

Br