Review request: IMAP providers: inline images are not shown in emails/New version for Fremantle release



Hello all,
Please, review the attached patch and integrate it if it looks fine.

Here is some info:
1) Baseline code location:
URL: http://git.gitorious.org/tinymail/tinymail.git
Branch: tinymail-1-2
Commit: ddb9efec849f8f2671869ea110426aa37a4706f8

2) Fix information:
* Regression since PR1.2 release: Inline images are not shown for IMAP providers Added '--disable-imap-part-fetch' to the configuration flags for maemo variant in the debian/rules.maemo file * Added new version to the change log (1.1.92), so we can integrate the updated code to Fremantle release.

Please, let me know if something is wrong with this fix.

If everything is fine, please, apply a tag to the latest commit, the tag might be '1.1.92'.

Thank you,
Alexander


Alexander Chumakov
Architect

Teleca
24 Salganskaya St., Nizhny Novgorod, 603105, Russia
Phone: +78312788198, Fax: +78312577230
Alexander Chumakov teleca com
http://www.teleca.com/

Follow what's going on at Teleca's blog on http://www.whatsyourideaoftomorrow.blogspot.com/.

The information contained in this message is confidential and is intended for the addressee(s) only. If you have received this message in error please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly prohibited.

>From 30953dcab74eedaf1effd33beab8e8b54c0d55de Mon Sep 17 00:00:00 2001
From: Alexander Chumakov <alexander chumakov teleca com>
Date: Tue, 13 Jul 2010 18:26:12 +0400
Subject: [PATCH 1/2] Added '--disable-imap-part-fetch' to the configuration flags for maemo variant

---
 ChangeLog          |    5 +++++
 debian/rules.maemo |    4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index e3e9e33..149d317 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2010-07-13  Alexander Chumakov  <alexander chumakov teleca com>
+
+        * debian/rules.maemo: Added '--disable-imap-part-fetch'
+        to the configuration flags for maemo variant
+
 2010-06-08  Alexander Chumakov  <alexander chumakov teleca com>
 
         * Added version 1.1.91 to the change log for PE1 Fremantle pre-release
diff --git a/debian/rules.maemo b/debian/rules.maemo
index ebe585d..4bc9643 100755
--- a/debian/rules.maemo
+++ b/debian/rules.maemo
@@ -28,10 +28,10 @@ ifneq (,$(findstring thumb,$(DEB_BUILD_OPTIONS)))
 endif
 
 config.status:
-	if [ ! -x configure ]; then ./autogen.sh --with-platform=maemo --with-ssl=nss --disable-idle; fi
+	if [ ! -x configure ]; then ./autogen.sh --with-platform=maemo --with-ssl=nss --disable-idle --disable-imap-part-fetch; fi
 	dh_testdir
 	# Add here commands to configure the package.
-	CFLAGS="$(CFLAGS) -fPIC" ./configure --with-platform=maemo --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr --with-ssl=nss --disable-idle --sysconfdir=/etc --mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info
+	CFLAGS="$(CFLAGS) -fPIC" ./configure --with-platform=maemo --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr --with-ssl=nss --disable-idle --disable-imap-part-fetch --sysconfdir=/etc --mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info
 
 
 build: build-stamp
-- 
1.7.0

>From 77e6f2c177ff0003379088419634bee1348f3e3e Mon Sep 17 00:00:00 2001
From: Alexander Chumakov <alexander chumakov teleca com>
Date: Tue, 13 Jul 2010 18:36:49 +0400
Subject: [PATCH 2/2] PE1 Fremantle release

---
 ChangeLog        |    2 ++
 debian/changelog |    6 ++++++
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 149d317..128f848 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,7 @@
 2010-07-13  Alexander Chumakov  <alexander chumakov teleca com>
 
+        * debian/changelog: Added version 1.1.92 to the change log
+        for PE1 Fremantle pre-release
         * debian/rules.maemo: Added '--disable-imap-part-fetch'
         to the configuration flags for maemo variant
 
diff --git a/debian/changelog b/debian/changelog
index e4817a1..c7a3b18 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+tinymail (1.1.92) unstable; urgency=low
+
+  * Fixes: NB#179769 IMAP providers: inline images are not shown in emails
+
+ -- Sergio Villar Senin <svillar igalia com>  Tue, 13 Jul 2010 18:30:00 +0400
+
 tinymail (1.1.91) unstable; urgency=low
 
   * Fixes: NB#160412 Return dynamically allocated string for mail (mime content) id
-- 
1.7.0



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]