[Tracker] localtime branch review

[Martyn Russell <martyn lanedo com>]

Hi all,

Jürg recently worked on the localtime branch to fix some of the issues 
we have with timezones and being able to convert between time/date 
values appropriately for the current locale. This is the review of that 
branch:

  http://git.gnome.org/browse/tracker/log/?h=localtime

--

1. The functions tracker_date_time_value_init() and _copy() are static 
and internal, shouldn't they avoid using the tracker_ namespace?


2. We should probably add some offset checking here for 
tracker_date_time_set(), offset must have a maximum. Assuming offset is 
in seconds it can only be 24 * 60 * 60 right?


3. tracker_date_time_set_from_string(), 
tracker_date_time_get_local_date() and 
tracker_date_time_get_local_time() all need parameter checking, 
g_return_...()


4. tracker-type-utils-test.c should probably test the offset too for 
tracker_string_to_date().


5. So from what I understand this approach uses localtime for composed 
tables and date+time columns for decomposed tables right? Just out of 
interest, why do we have two columns for date/time in the decomposed 
tables (just trying to understand that's all)?

--

Other than that, I couldn't see any problems with the branch. Good work 
Jürg.

--
Regards,
Martyn