Re: [Vala] [PATCH] add missing XStringToKeysym() function to x11.vapi

[Luca Bruno <lethalman88 gmail com>]

On Thu, Mar 31, 2011 at 02:57:21AM +0200, Alexander Kurtz wrote:
> I am almost finished with adding all XFooToBar() functions, but I think
> I found another bug:
>
> The current x11 bindings say:
>       KeySym == uint
>       KeyCode == int
>
> However, the header files say something else:
>
>       $ grep -r typedef /usr/include/X11/ | grep 'KeySym;'
>       /usr/include/X11/X.h:typedef XID KeySym;
>       $ grep -r typedef /usr/include/X11/ | grep 'XID;'
>       /usr/include/X11/Xdefs.h:typedef unsigned long XID;
>       /usr/include/X11/Xdefs.h:typedef CARD32 XID;
>       /usr/include/X11/X.h:typedef unsigned long XID;
>       /usr/include/X11/X.h:typedef CARD32 XID;
>       $ grep -r typedef /usr/include/X11/ | grep 'KeyCode;'
>       /usr/include/X11/X.h:typedef unsigned char KeyCode;
>       $ 
>
> According to the header files this would be correct:
>
>       KeySym == ulong
>       KeyCode == uchar
>
> If I use the old definitions, I get segfaults when using XConvertCase().
> With the new definitions everything works fine.
>
> Can you confirm that the new definitions are correct before I submit my
> final patch?

Looks ok to me as far as you tested those changes.

-- 
http://www.debian.org - The Universal Operating System

Attachment: signature.asc
Description: Digital signature