Re: [gnome-db] New patch. Closes bug #68577

[Rodrigo Moya <rodrigo gnome-db org>]

On Fri, 2002-01-18 at 01:35, Gonzalo Paniagua Javier wrote:
> * [ Rodrigo Moya <rodrigo gnome-db org>
> * Fri, 18 Jan 2002 00:38:08 +0100 ]
> > >  	cmd = GNOME_Database_Command__alloc ();
> > >  	gda_command_set_text (cmd, text);
> > >  	gda_command_set_command_type (cmd, type);
> > > +	cmd->option = GDA_COMMAND_OPTION_BAD_OPTION;
> > > +	gda_command_set_option (cmd, option);
> > > +	if (cmd->option == GDA_COMMAND_OPTION_BAD_OPTION)
> > > +		cmd->option = GDA_COMMAND_DEFAULT_OPTION;
> > >  
> 
> 	I think this is ok. I set a wrong value to option. Then call
> 	gda_command_set_options() that leaves cmd->option untouched if
> 	there are conflicts so, when it returns, cmd->option is still
> 	GDA_COMMAN_OPTION_BAD_OPTION, and then I put the default
> 
yes, you're right. Leave this on.

cheers
-- 
Rodrigo Moya <rodrigo gnome-db org> - <rodrigo ximian com>
http://www.gnome-db.org/ - http://www.ximian.com/