Re: strange gnome-terminal behaviour [PATCH] for gdm



Could someone see if the following patch make sense, and in that case
apply it? This resolves a problem causing gnome-terminal to hang (since
gdm caused the SIGCHLD signal to remain blocked, I think).

I think that here the old mask is saved in omask, and then never restored.

Index: gdmslave.c
===================================================================
RCS file: /cvs/gnome/gdm/src/gdmslave.c,v
retrieving revision 1.41
diff -c -r1.41 gdmslave.c
*** gdmslave.c	1999/02/24 22:25:48	1.41
--- gdmslave.c	1999/04/17 10:28:01
***************
*** 303,310 ****
  	    kill(d->greetpid, SIGINT);
  	    waitpid(d->greetpid, 0, 0); 
  	    d->greetpid=0;
! 	    
! 	    sigprocmask(SIG_UNBLOCK, &omask, NULL);
  	    
  	    /* Kill clients started by Init script */
  	    if(GdmKillInitClients)
--- 303,310 ----
  	    kill(d->greetpid, SIGINT);
  	    waitpid(d->greetpid, 0, 0); 
  	    d->greetpid=0;
! 
! 	    sigprocmask(SIG_SETMASK, &omask, NULL);
  	    
  	    /* Kill clients started by Init script */
  	    if(GdmKillInitClients)

Hope this helps!
Zun.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]