Re: [BuildStream] [Proposal] Plugin fragmentation / Treating Plugins as Sources

[Tristan Van Berkom <tristan vanberkom codethink co uk>]

On Sat, 2019-04-13 at 21:25 +0100, Angelos Evripiotis wrote:
> Happy weekend both! :)

Happy weekend Angelos :)

> On Fri, Apr 12, 2019 at 8:36 AM Tristan Van Berkom
> > <tristan vanberkom codethink co uk> wrote:
>
> > My idea of a `venv` origin is that every version of every BuildStream
> > plugin from this origin, lives in it's own, isolated venv (i.e. my idea
> > would have been to "make it actually safe").
> > As far as I can see, this would require that we never instantiate
> > plugins in the main BuildStream process, and also that we never assume
> > that it is okay to have two plugins instatiated in the same process.
>
> I like the idea of per-plugin venvs too, I have a feeling that we can
> have them co-exist in the same process though, with some extra
> PluginBase-like-import-magic . Is this what you are also thinking
> Chandan? I wasn't totally clear. Perhaps it's not as simple as that;
> I'm keen to dig deeper.

Indeed.

So honestly, while I do feel it is a bit overkill for our needs, I can
see that both of you are keen on this idea, and I do admit to finding
it "neat" if we could do it.

It seems a bit more challenging, if we do go ahead with this; could I
assume to get assistance from you to solve the challenge of making this
part actually work ?

Cheers,
    -Tristan