[damned-lies] Stop updating doc stats when unbuildable pot file
- From: Claude Paroz <claudep src gnome org>
- To: svn-commits-list gnome org
- Subject: [damned-lies] Stop updating doc stats when unbuildable pot file
- Date: Sat, 16 May 2009 10:34:59 -0400 (EDT)
commit 422ff8b73ea9942e2983011d8e3ad47d6896c51f
Author: Claude Paroz <claude 2xlibre net>
Date: Sat May 16 16:30:00 2009 +0200
Stop updating doc stats when unbuildable pot file
When the doc pot file is not returned by generate_doc_pot_file,
abort generating stats. Statistics object is also prepared a little
later so as no stat is created/modified in DB in such cases.
---
stats/models.py | 17 +++++++++++------
1 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/stats/models.py b/stats/models.py
index f6162af..e66272f 100644
--- a/stats/models.py
+++ b/stats/models.py
@@ -292,12 +292,6 @@ class Branch(models.Model):
if not os.access(domain_path, os.X_OK):
# TODO: should check if existing stats, and delete (archive) them in this case
continue
- try:
- stat = Statistics.objects.get(language=None, branch=self, domain=dom)
- Information.objects.filter(statistics=stat).delete() # Reset errors
- except Statistics.DoesNotExist:
- stat = Statistics(language=None, branch=self, domain=dom)
- stat.save()
errors = []
# 2. Pre-check, if available (intltool-update -m)
@@ -312,12 +306,23 @@ class Branch(models.Model):
potfile, errs = dom.generate_pot_file(domain_path)
elif dom.dtype == 'doc': # only gnome-doc-utils toolchain supported so far for docs
potfile, errs = utils.generate_doc_pot_file(domain_path, dom.potbase(), self.module.name, settings.DEBUG)
+ if not potfile:
+ print >> sys.stderr, "\n".join([e[1] for e in errs])
+ continue
doclinguas = utils.read_makefile_variable(domain_path, "DOC_LINGUAS").split()
else:
print >> sys.stderr, "Unknown domain type '%s', ignoring domain '%s'" % (dom.dtype, dom.name)
continue
errors.extend(errs)
+ # Prepare statistics object
+ try:
+ stat = Statistics.objects.get(language=None, branch=self, domain=dom)
+ Information.objects.filter(statistics=stat).delete() # Reset errors
+ except Statistics.DoesNotExist:
+ stat = Statistics(language=None, branch=self, domain=dom)
+ stat.save()
+
# 4. Compare with old pot files, various checks
# *****************************
previous_pot = os.path.join(self.output_dir(dom.dtype), dom.potbase() + "." + self.name + ".pot")
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]