[gdm: 4/4] Move Shutdown functions to panel instead of login window
- From: Ray Strode <halfline src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [gdm: 4/4] Move Shutdown functions to panel instead of login window
- Date: Tue, 20 Oct 2009 21:59:33 +0000 (UTC)
commit 7b3be6884096a2d21af3c6c26090641c16988b15
Merge: f0a0955... 4c20614...
Author: Ray Strode <rstrode redhat com>
Date: Tue Oct 20 17:56:09 2009 -0400
Move Shutdown functions to panel instead of login window
Robert Ancell gives a good rationale for the move:
"In GDM 2.28/master on startup the user is presented with a window
containing:
- A list of users to log in as with the first user selected
- Two buttons, restart and shutdown, below the user list
Since the first user is selected, users who are unfamiliar/not paying
close attention sometimes click on the shutdown button as this is placed
where the default action (in this case login) is conventionally placed
(the lower right hand corner of the window). The penalty of making this
mistake is for the computer to shut down immediately with no chance of
aborting this mistake.
An additional mistake users can make is to miss clicking on their user
and then click on the shutdown button (as this button is replaced with
the login button after selecting a user).
Recommended behaviour:
Move the shutdown actions (shutdown, sleep, hibernate, restart) to a
menu on the GDM panel.
The shutdown buttons do not need to be prominently located as:
- They are used less frequently than the login buttons (normal operation
is to shutdown from within your session).
- Most hardware has a dedicated power button that performs the same
action
- It is better to have them in a location where they are less likely to
be accidentally activated"
(see https://bugs.gnome.org/596151)
gui/simple-greeter/Makefile.am | 2 +-
gui/simple-greeter/gdm-greeter-login-window.c | 294 -------------------
gui/simple-greeter/gdm-greeter-login-window.glade | 194 -------------
gui/simple-greeter/gdm-greeter-panel.c | 310 ++++++++++++++++++++-
gui/simple-greeter/gdm-greeter-panel.h | 3 +-
gui/simple-greeter/gdm-greeter-session.c | 4 +-
gui/simple-greeter/test-greeter-panel.c | 2 +-
7 files changed, 314 insertions(+), 495 deletions(-)
---
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]