[libgnomekbd] config: plug minor leak
- From: Sergey V. Udaltsov <svu src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libgnomekbd] config: plug minor leak
- Date: Thu, 22 Mar 2012 09:23:06 +0000 (UTC)
commit a6ca20e027edf43df578c7cf1aa26eecb6512540
Author: Ray Strode <rstrode redhat com>
Date: Wed Mar 21 16:51:28 2012 -0400
config: plug minor leak
gkbd_keyboard_config_split_items allocates its out args, but
those allocations aren't getting cleaned up in
gkbd_keyboard_config_copy_to_xkl_config
This commit plugs that leak.
https://bugzilla.gnome.org/show_bug.cgi?id=670164
libgnomekbd/gkbd-keyboard-config.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/libgnomekbd/gkbd-keyboard-config.c b/libgnomekbd/gkbd-keyboard-config.c
index acd5456..397df24 100644
--- a/libgnomekbd/gkbd-keyboard-config.c
+++ b/libgnomekbd/gkbd-keyboard-config.c
@@ -309,9 +309,11 @@ gkbd_keyboard_config_copy_to_xkl_config (GkbdKeyboardConfig * kbd_config,
char *group, *option;
if (gkbd_keyboard_config_split_items
(*the_option, &group, &option)
- && option != NULL)
+ && option != NULL) {
*(p++) = g_strdup (option);
- else {
+ g_free (group);
+ g_free (option);
+ } else {
*(p++) = g_strdup ("");
xkl_debug (150, "Could not split [%s]\n",
*the_option);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]