[gnome-shell] ScreenShield: fix fallout from 8cb3884
- From: Giovanni Campagna <gcampagna src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] ScreenShield: fix fallout from 8cb3884
- Date: Thu, 31 Jan 2013 12:46:06 +0000 (UTC)
commit 9ab22fe5519149515571128448ca0cb27805ccb6
Author: Giovanni Campagna <gcampagna src gnome org>
Date: Thu Jan 31 13:33:31 2013 +0100
ScreenShield: fix fallout from 8cb3884
We must remove music notifications before we're destroyed, otherwise
they get destroyed with us.
Also, integrate a review comment I previously forgot.
https://bugzilla.gnome.org/show_bug.cgi?id=685926
js/ui/screenShield.js | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
---
diff --git a/js/ui/screenShield.js b/js/ui/screenShield.js
index 0367f60..73bf137 100644
--- a/js/ui/screenShield.js
+++ b/js/ui/screenShield.js
@@ -218,9 +218,11 @@ const NotificationsBox = new Lang.Class({
continue;
let body = '';
- if (n.bannerBodyText)
+ if (n.bannerBodyText) {
body = n.bannerBodyMarkup ? n.bannerBodyText :
GLib.markup_escape_text(n.bannerBodyMarkup, -1);
+ }
+
let label = new St.Label({ style_class: 'screen-shield-notification-count-text' });
label.clutter_text.set_markup('<b>' + n.title + '</b> ' + body);
textBox.add(label);
@@ -356,6 +358,11 @@ const NotificationsBox = new Lang.Class({
obj.sourceBox.destroy();
obj.sourceBox = obj.titleLabel = obj.countLabel = null;
+ if (obj.musicNotification) {
+ this._musicBin.child = null;
+ obj.musicNotification = null;
+ }
+
source.disconnect(obj.sourceDestroyId);
source.disconnect(obj.sourceCountChangedId);
source.disconnect(obj.sourceTitleChangedId);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]