[tracker] tracker-extract: items==0 doesn't imply failure
- From: Carlos Garnacho <carlosg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [tracker] tracker-extract: items==0 doesn't imply failure
- Date: Tue, 4 Aug 2015 17:39:41 +0000 (UTC)
commit a260c3a7ab8e3b29142b5978bc5f40ad38af3892
Author: Carlos Garnacho <carlosg gnome org>
Date: Tue Aug 4 18:55:27 2015 +0200
tracker-extract: items==0 doesn't imply failure
There may be files where there's just nothing to be extracted, make
these fall through the success code paths. If a module fails for
any reason, it must return FALSE on the get_metadata func.
src/tracker-extract/tracker-extract.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/src/tracker-extract/tracker-extract.c b/src/tracker-extract/tracker-extract.c
index 4e6a7eb..a771c95 100644
--- a/src/tracker-extract/tracker-extract.c
+++ b/src/tracker-extract/tracker-extract.c
@@ -333,10 +333,10 @@ get_file_metadata (TrackerExtractTask *task,
statements = tracker_extract_info_get_metadata_builder (info);
items = tracker_sparql_builder_get_length (statements);
- if (success && items > 0) {
+ if (items > 0)
tracker_sparql_builder_insert_close (statements);
- task->success = TRUE;
- }
+
+ task->success = success;
}
g_free (mime_used);
@@ -344,14 +344,14 @@ get_file_metadata (TrackerExtractTask *task,
g_debug ("Done (%d objects added)\n", items);
- if (!success || items == 0) {
+ if (!success) {
tracker_extract_info_unref (info);
info = NULL;
}
*info_out = info;
- return (success && items > 0);
+ return success;
}
/* This function is called on the thread calling g_cancellable_cancel() */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]