Re: gnome-session patch ...
- From: Mark McLoughlin <mark skynet ie>
- To: Michael Meeks <michael ximian com>
- Cc: desktop-devel-list gnome org, Jacob Berkman <jacob ximian com>
- Subject: Re: gnome-session patch ...
- Date: Wed, 17 Jul 2002 05:04:28 +0100 (IST)
(replying to myself for the second time in as many hours)
On Wed, 17 Jul 2002, Mark McLoughlin wrote:
> Some comments:
>
> 1) You should use GnomeIconLoader to locate the icons so they
> can be themed.
> 2) You seem to scale the icon unconditionally (or am I missing
> something) - should you not check to see if the pixbuf is
> already the desired size first ?
> 3) The unref after destroying the splash is bogus right ?
> 4) As someone else mentioned this remvoes our dependacy on
> the canvas - could oyu updated configure.in accordingly ?
> 5) The ChangeLog entry could give just a little more info on
> what the change actually accomplishes ... :-)
6) The button release handler doesn't work because you haven't
selected button release events.
Good Luck,
Mark.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]