Re: TARBALLS DUE: GNOME 2.4 D&DP ***FINAL***

[Kjartan Maraas <kmaraas broadpark no>]

tir, 09.09.2003 kl. 13.24 skrev Alan Cox:
> > > Duh.. in gweather, would help if I didnt assume telepathy on the part of
> > > the maintainers, they may be wizards but thats going too far 8)
> > 
> > What's the easy way to trigger it? I'll run it under valgrind for a
> > while and see what turns up...
> 
> Every time it refreshes (or you force a reload) it leaks a file handle

With some help from Christophe Fergeau I got this together, does that
look like it's going to fix it?

Cheers
Kjartan

? gweather-leak-fix.patch
? gweather.schemas
Index: location.c
===================================================================
RCS file: /cvs/gnome/gnome-applets/gweather/location.c,v
retrieving revision 1.3
diff -u -r1.3 location.c
--- location.c	16 Jun 2003 15:31:19 -0000	1.3
+++ location.c	9 Sep 2003 12:43:57 -0000
@@ -122,6 +122,11 @@
  	return TRUE;
 }
 
+static void
+dummy_close_cb ()
+{
+}
+
 static void 
 finish_read(GnomeVFSAsyncHandle *handle, GnomeVFSResult result, 
 		      gpointer buffer, GnomeVFSFileSize requested, 
@@ -158,8 +163,8 @@
 							    finish_read, applet);
 		return;
     	}
-
-	 g_free (buffer);
+	gnome_vfs_async_close (handle, dummy_close_cb, NULL)
+	g_free (buffer);
 }