Re: patch to gnome-session: smooth fade on logout

[Calum Benson <Calum Benson Sun COM>]

JDS has a different 'fade on logout' effect from community GNOME too, 
btw... Matt wrote it IIRC.  Perhaps he could forward you that patch too, 
and you can decide which one is more suitable for inclusion...

Cheeri,
Calum.


Ross Girshick wrote:
> Judging by the patch, the original code is designed to perform a fade 
>
> > out over a fixed period of time (so slower machines would render less 
> > frames in the animation).  Your patch appears to change things so that 
> > it fades out in a fixed number of frames.  How will this affect the time 
> > required to log out on slower machines?
>
>
> James,
>
> That's correct that the original patch was designed to fade out over 1.5
> seconds (though the comment says 5). My original patch had a slight
> error in how it handled slowing the frame rate, but I've sent a fixed
> version to Mark. My patch (with the fix I sent to Mark) does use a fixed
> number of frames, but it also calls usleep if it needs to wait for a
> little bit, after rendering the new frame, so that it fades over
> approximately 1.5 seconds. As for slower machines, perhaps I need to add
> it some code to prevent the fade from laster for too long -- though it
> may not be needed now that the algorithm is much faster. I'll try to do
> some testing on an older, slower laptop later today.
>
> Ross
>
> _______________________________________________
> desktop-devel-list mailing list
> desktop-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/desktop-devel-list